Chromium Linux ChangeLog

I compile the Chromium web browser daily from source, sometimes even multiple times. I found there was no easy way to follow the Chromium ChangeLog, so I created one specifically for the Linux branch which I can also search though (supports Boolean eg: +bookmarks -sync).

Below is the entire online Chromium Linux ChangeLog extracted from all the binary builds available for download (32bit |64bit). The ChangeLog below is updated every 15 minutes.

#Build Date Notes
#543932010-07-30 22:04:35Cr.js: Allow cr.define to export getters and setters.

There was a bug in the export code for exporting properties since it was just doing a simple [[Get]] which breaks cr.doc as well as the option to have singletons created lazily by the getter.

BUG=None
TEST=Options and Bookmarks should still work.

Review URL: http://codereview.chromium.org/3031035
#543922010-07-30 22:00:38Remove some wstrings used in ui_test.cc.

This removes all switch-related wstring APIs from ui_test.cc, and fixes all the callers.

Review URL: http://codereview.chromium.org/3066026
#543912010-07-30 21:53:35Refine the tool so that, it binary searches for the extensions that crashes the browser (if there is one).

Review URL: http://codereview.chromium.org/3060021
#543892010-07-30 21:52:57Add --enable-speech-input switch and set ENABLE_INPUT_SPEECH=1

Flip the compile-time enable switch for speech input to on and add a command-line switch to put the functionality behind. The command-line flag will be used both on the Chromium side and in WebKit via WebRuntimeFeatures.

This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146

BUG=none
TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.*

Originally Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54235, but reverted due to tests failure.

Review URL: http://codereview.chromium.org/3064017
#543882010-07-30 21:49:03More FRIEND_TEST_ALL_PREFIXES.

TEST=none
BUG=44549

Review URL: http://codereview.chromium.org/3053024
#543872010-07-30 21:42:37Mac: Let task manager columns span entire window immediately.

BUG=32148
TEST=Open task manager. It should immediately look like it did if you opened it and then resized it by 1px previously.

Review URL: http://codereview.chromium.org/3056036
#543862010-07-30 21:37:44[Mac] Give page actions a default image when preview enabled.

During install it is possible to display (or layout) the action before the images have come in. Provide a default image for this case.

BUG=50771
TEST=See bug.

Review URL: http://codereview.chromium.org/3047031
#543832010-07-30 21:24:39Pepper2 audio (trusted side) implementation. Still missing a synchronization for the callback setting, will be done soon.

BUG=none
TEST=test plugin plays music

Review URL: http://codereview.chromium.org/2962003
#543812010-07-30 21:20:12Revert 54378 - Add content-length to spdy post request header.

http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac10.6%20(dbg)/builds/9160

TEST=spdy_network_transaction_unittest.cc BUG=50545
Review URL: http://codereview.chromium.org/3023029

TBR=lzheng@google.com
Review URL: http://codereview.chromium.org/3041035
#543802010-07-30 21:14:03Revert "Incorporate 'quick' history provider index as an autocomplete ..."

Broke AutocompleteEditViewTest.DesiredTLD and AutocompleteEditView.EscapeToDefaultMatch on Linux.

TBR=mrossetti

Review URL: http://codereview.chromium.org/3052031
#543782010-07-30 21:08:34Add content-length to spdy post request header.

TEST=spdy_network_transaction_unittest.cc BUG=50545
Review URL: http://codereview.chromium.org/3023029
#543762010-07-30 20:52:36Initialize salt_ to zero in VisitedLinkCommon.

Previously, this memory would remain uninitialized until the renderer received a VisitedLink_NewTable message. This was causing valgrind errors in PhishingDOMFeatureExtractorTest when WebKit computed URL fingerprints, since the test never sends a VisitedLink_NewTable message.

BUG=none
TEST=no valgrind errors in PhishingDOMFeatureExtractorTest

Review URL: http://codereview.chromium.org/2873081
#543732010-07-30 20:39:31Add undeclared virtual destructors part 3

Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.

These files were discovered using the -Wnon-virtual-dtor flag in g++.

r=jar
BUG=47469


Review URL: http://codereview.chromium.org/3072010
#543672010-07-30 20:07:56Revert 54363 since it adds a runtime dependency on MSVCR80.dll.

TBR=mal

Review URL: http://codereview.chromium.org/3057026
#543662010-07-30 20:07:48Handle a case if BindContextInfo::FromBindContext fails and not leak a ProtData instance.

BUG=none
TEST=fixes a potential memory leak.

Review URL: http://codereview.chromium.org/2832097
#543642010-07-30 20:00:43Remove heapcheck suppression for 50583.

BUG=50583
TEST=none

Review URL: http://codereview.chromium.org/3046032
#543632010-07-30 20:00:30Add d3dx9_42.dll, libEGL.dll, and libGLESv2.dll to the distributed builds.

R=mal

Review URL: http://codereview.chromium.org/3032040
#543612010-07-30 19:58:03ffmpeg deps roll to fix chrome builds on 32 bit linux BUG=50784
TEST=build chrome branded 32 bit ffmpeg

Review URL: http://codereview.chromium.org/3061038
#543592010-07-30 19:47:47Convert DictionaryValue's keys to std::string (from wstring).

Everything now needs to be changed to avoid the deprecated wstring methods; this includes the unit tests.

BUG=23581
TEST=all our tests still pass

Review URL: http://codereview.chromium.org/3075010
#543582010-07-30 19:39:52Add a newline to the end of the unit test file.

TEST=it compiles
#543572010-07-30 19:35:01Selection model refactoring.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3025014
#543562010-07-30 19:32:20Widen CoreAudio suppression.

This started failing with a new caller (fun:AudioObjectAddPropertyListener) in Mac Valgrind (2) bot

http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20UI%20(valgrind)(2)/builds/3734

BUG=9351
TEST=None

Review URL: http://codereview.chromium.org/3071010
#543552010-07-30 19:28:44Move the number conversions from string_util to a new file.

Use the base namespace in the new file. Update callers.

I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.

TEST=included unit tests
BUG=none

Review URL: http://codereview.chromium.org/3056029
#543542010-07-30 19:25:58Incorporate 'quick' history provider index as an autocomplete provider in preparation for the replacement of the current history_url_provider. This step refactors the history provider code a bit, introduces the replacement class (history-quick_provider), and adds a unittest template. Note that the 'quick' provider will only support the fast, synchronous autocomplete pass. Once the quick provider has been completed the current history_url_provider will be replaced. In the meantime, the latter will remain in operation in order to provide the slower history results.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3017008
#543512010-07-30 19:07:04Add new flimflam error codes.
BUG=chromium-os:1078
TEST=none
Review URL: http://codereview.chromium.org/3018029
#543502010-07-30 19:05:48Moved option-related JS classes behind options namespace

BUG=none
TEST=make sure options still work

Review URL: http://codereview.chromium.org/3027003
#543492010-07-30 18:32:35Mac: Add tabpose window

The window doesn't have any contents yet, which makes its appearance look a bit janky for now.

BUG=50307
TEST=
* All the following happens only if --enable-expose-for-tabs is passed in, else all of it should be disabled.
* In a browser window, hit cmd-f10 or three-finger-swipe down. A grey overlay with a gradient at the top should appear.
* The overlay should cover tab contents, eventual info bars, the bookmarks bar if it's detached (but not the bookmarks bar if it's not detached), and eventual attached inspector windows. It should not cover the download shelf if it's open.
* The window should block clicks on the tab strip and the download shelf for now.
* The overlay should close on three-finger-swipe up, click, esc, enter, and space.
* Every open browser window should have its own overlay, and they should be independent of each other.
* If a browser window with an overlay window is active, most menu items should be greyed out, and all browser-related keyboard shortcuts should be disabled.
* In particular, hitting cmd-f10 twice should open only one overlay per browser window
* The overlay should have the correct size with a UI scale factor > 1

Review URL: http://codereview.chromium.org/2819070
#543482010-07-30 18:26:16Revert timeout value for sync integration tests.

The XP bots still need a longer timeout for the sync integration tests, so I'm reverting my earlier change to the timeout value.

Also fixing an issue where InProcessBrowserTest::TimedOut() incorrectly reports the current value of timeout.

TBR=timsteele
BUG=50589,50590
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3077009
#543452010-07-30 18:12:06Suppression for http://crbug.com/50766

BUG=50766
TEST=None

Review URL: http://codereview.chromium.org/2832098
#543442010-07-30 18:11:36Disable tests failing on official builders

downloads.DownloadsTest.testZip -- fails on official win builder when run thru buildbot only. runs fine when run manually

codesign -- codesign tests should be run *after* the build has been signed

BUG=50481
TEST=pyauto_functional_tests go green on official mac, win builders

Review URL: http://codereview.chromium.org/2825078
#543422010-07-30 17:59:16Mark BrowserFocusTest.TabInitialFocus as FLAKY.

We've seen some flaky flips July 19th, but it still might be caused by more recent changes like my download cleanup or other changes that have landed recently.

More data in the bug.

TBR=jcivelli,suzhe,oshima

TEST=BrowserFocusTest.TabInitialFocus
BUG=50763

Review URL: http://codereview.chromium.org/3017046
#543412010-07-30 17:47:52Mark KeyboardAccessTest.ReserveKeyboardAccelerator as FAILS

It has been re-added in http://codereview.chromium.org/3029038/show

TBR=pkasting (to re-route to the test author)

TEST=KeyboardAccessTest.ReserveKeyboardAccelerator BUG=50760

Review URL: http://codereview.chromium.org/2819082
#543402010-07-30 17:45:27Exclude AutoFillManagerTest.GetBillingSuggestionsAddress1 from running in branded builds.

BUG=50537
TEST=unit_tests should pass in branded builds. Review URL: http://codereview.chromium.org/3068013
#543392010-07-30 17:43:17Use a plain ASCII string for the UI locale in the plugin service.

Removes a few needless conversions.

Review URL: http://codereview.chromium.org/3075012
#543382010-07-30 17:42:24Use a few more FilePaths in bookmark import.

Removes some wstrings.

BUG=24672

Review URL: http://codereview.chromium.org/2819080
#543362010-07-30 17:37:35Deflake ListenSocketTest.ServerSend and remove unused telnet code.

http://codereview.chromium.org/2847089/show

BUG=48562
TEST=net_unittests
#543352010-07-30 17:34:53Add back experimental* pages for APIs that have graduated from experimental to supported. Otherwise, it's hard to know what happened to that API you were experimenting with...

TEST=none
BUG=none
TBR=erikkay
Review URL: http://codereview.chromium.org/2868084
#543342010-07-30 17:32:17Reland r54074.
Review URL: http://codereview.chromium.org/3010040
#543332010-07-30 17:22:16Initialize SpdyStreamMember to kInitialWindowSize.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/3081004
#543322010-07-30 17:16:11Fix a bug with detecting window sizes that match the monitor size.

The previous code was comparing the window size to the screen size, but that doesn't work properly for twinview or other cases where there are multiple monitors that make up a single screen. Instead, compare the window size against all monitors (since we don't know which monitor the window is going to be placed on) and resize if it matches any monitor size.

Also fix a bug in BoundsMatchMonitorSize where we should just be comparing sizes, not rectangle positions.

BUG=32347

Review URL: http://codereview.chromium.org/3060032
#543312010-07-30 17:00:34When running as a remote, call gdk_notify_startup_complete

Linux programs are expected to notify their launcher when they finish loading. GTK+ does this automatically when the first GtkWindow is opened. When acting as a remote, no window is opened, so we should manually send the notification.

This could perhaps be more thorough and pass DESKTOP_LAUNCH_ID to the remote to call with gdk_notify_startup_complete_with_id, but a quick survey on codesearch suggests that no one bothers anyway.

(This is reproducible in KDE. The bug report suggests some configurations of GNOME need this as well, but not yet reproducible.)

R=estade
BUG=45392
TEST=throbber disappears on second Chrome launch in KDE

Review URL: http://codereview.chromium.org/3051023
#543252010-07-30 15:58:34[Mac] Make popup-blocked animation animate to content-setting icon.

BUG=none
TEST=www.popuptest.com, click a page to cause popups. Animation should go to where the blocked-popup content-setting decoration is in the omnibox.

Review URL: http://codereview.chromium.org/3014029
#543242010-07-30 15:49:22Add unittest for ".." in a DNS name and add comment.

(This is a follow up to r53782.)
#543232010-07-30 15:33:28Remove some debug switches:

--issue35198-crxdir-browser
--issue35198-permission

They were used to understand issue 35198. They are no longer needed. There is one more switch, --issue35198-logging, that is not being removed in this CL. The logging it adds may still be useful.

BUG=50604
TEST=manual

Review URL: http://codereview.chromium.org/3052023
#543222010-07-30 15:28:52Widening suppression for DownloadsDOMHandler::ModelChangedEv

BUG=50745
TEST=None

Review URL: http://codereview.chromium.org/3051027
#543212010-07-30 15:22:26Shuffle some of the functions in file_util.h.

(A followup from r54316.)
#543202010-07-30 15:17:22[Mac] Reposition the status bubble whenever adding it to a window.

BUG=50599
TEST=Open a window and let its webpage load. Move the window left or right, without allowing the mouse to pass over the web area. Then type in a new url and load it, again without letting the mouse pass over the web area. Status bubble should appear in the proper place. Review URL: http://codereview.chromium.org/3041028
#543142010-07-30 14:32:22Deflake KeygenHandlerTest.FLAKY_SmokeTest

Key generation is a process which inheriently has a long tail. 2048-bit keys are probably too large to generate on the bots if we expect them to complete in a reasonable amount of time.

Thus we dial down the modulus size and remove the FLAKEY tag.

BUG=none
TEST=none

http://codereview.chromium.org/2808081/show
#543132010-07-30 14:28:01OEM EULA extracted correctly from manifest. Fixing CustomizationDocument to return full path to the pages being queried.

BUG=chromium:3178
TEST=none

Review URL: http://codereview.chromium.org/2878051
#543122010-07-30 14:16:57Work around multiple bugs in the WrenchMenuControllerTest using a bit of hackery.

BUG=49206
TEST=Unit tests pass regularly.

Review URL: http://codereview.chromium.org/3017044
#543112010-07-30 14:01:59file_util: Get rid of file_util::AppendToPath in icon_util_unittest.cc

Use AppendASCII from FilePath API instead of the deprecated AppendToPath function.

BUG=24672
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Review URL: http://codereview.chromium.org/3046020
#543102010-07-30 13:40:19Fixes transition from account creation screen to images login screen.

BUG=None
TEST=Create user account and verify that images login screen is shown and the new user logs in.

Review URL: http://codereview.chromium.org/3057020
#543092010-07-30 12:45:37Add title for "ask" button on mac.

TEST=unit_tests of mac
BUG=50083
TBR=jochen@chromium.org

Review URL: http://codereview.chromium.org/3051025
#543082010-07-30 12:01:19Command line flag to disable the cookie prompt.

The XIB change re-introduces the cookie tab view item with the "ask" setting as additinoal tab view item. The controller deletes the one not required according to the command line flag.

BUG=50083
TEST=none

Review URL: http://codereview.chromium.org/3075013
#543032010-07-30 10:57:52Use new update API during OOBE.
Add test shortcut for register screen.

BUG= http://crosbug.com/4483 http://crosbug.com/4003 http://crosbug.com/4002 TEST=Manual - update during OOBE should work and reboot if update has been installed.

Review URL: http://codereview.chromium.org/2832088
#543022010-07-30 10:53:34Memcheck suppressions.

Extend a suppression for bug 49404
Suppress uninitialized memory in Webkit (bug 50728) Suppress a leak in Browser::ShowDownloadsTab (bug 50729)


BUG=49404,50728,50729

Review URL: http://codereview.chromium.org/3026035
#542972010-07-30 10:00:43Updating trunk VERSION from 480.0 to 481.0
#542922010-07-30 08:17:15Reinstating the call to InitiateNavigation when we launch the url from our active document. This is needed to pass the referrer correctly to chrome.

TBR=amit

Review URL: http://codereview.chromium.org/3080012
#542892010-07-30 06:18:17Build fix.
#542882010-07-30 06:09:40Use notification-based API for getting system proxy settings on Mac rather than polling.

BUG=50587
Review URL: http://codereview.chromium.org/3078009
#542872010-07-30 06:01:13Use an integer for the port parameter to the UI test HTTP server.

Review URL: http://codereview.chromium.org/2884054
#542862010-07-30 06:00:38Drop usage of IntToWString in switch values; we can use ASCII now.

Review URL: http://codereview.chromium.org/3037034
#542852010-07-30 05:59:57Convert a bunch of easy AppendSwitchWithValue to *ASCII.

For this patch, I skipped over any instance where it wasn't a nearly trivial change.

Review URL: http://codereview.chromium.org/3069014
#542842010-07-30 05:54:21Miscellaneous ChromeFrame code cleanup. The automation client class maintained GURL members holding the url and referrer. We can stuff this information into the ChromeFrameLaunchParams member maintained by the client. This reduces the complexity in the code related to detecting whether we can navigate up front or after chrome initialization.

The ChromeFrame ActiveX now launches the automation server in its implementation of IPersistPropertyBag::Load. This avoids race conditions between launching the automation server and navigating to it via put_src.

Review URL: http://codereview.chromium.org/3038038
#542832010-07-30 05:50:42Add unit tests for base/platform_thread.* and base/lock.*.

BUG=none
TEST=base_unittests

Review URL: http://codereview.chromium.org/3030025
#542802010-07-30 05:35:12AutoFill: Determine credit card type based on the CC number and display the appropriate CC icon.

BUG=50080
TEST=none

Review URL: http://codereview.chromium.org/3010041
#542792010-07-30 05:30:13Fix a typo, that could cause a crash on mac.

BUG=50717
TBR=rvargas
TEST=Set system proxy settings to use a custom PAC script, then launch TestShell.app -- should not crash. Review URL: http://codereview.chromium.org/3023030
#542662010-07-30 03:25:47Disable the page_cycler_database on Windows, because it's really slow on XP and Vista. Submitting without waiting for review, because the
"XP Perf (webkit.org)" is timing out because of this suite.

BUG=40123
TEST=none
TBR=chase@chromium.org


Review URL: http://codereview.chromium.org/3047026
#542622010-07-30 02:58:58Must clear all references to buttons representing a bookmark when that bookmark gets deleted.

BUG=50381
TEST=1) Bring up a bookmark folder which can be scrolled. 2) Scroll it a bit. 3) Cut or delete a bookmark using the contextual menu. 4) Scroll using the mouse scroll wheel. If there is no crash at this point then the bug has been fixed.

Review URL: http://codereview.chromium.org/3030029
#542612010-07-30 02:51:31Update bug number for Snippets.FAILS_ThaiUTF8.

BUG=50705
TEST=Snippets.FAILS_ThaiUTF8

Review URL: http://codereview.chromium.org/3079010
#542602010-07-30 02:35:35Use relative instead of absolute URIs in SPDY requests

BUG=50549
TEST=existing

Review URL: http://codereview.chromium.org/3035037
#542592010-07-30 02:22:35Reland r53603 - Make the OmniboxSearchHint infobar use PAGE_ACTION_TYPE.

This reverts commit 893e3e083fe8d77949860cdb1af7fc14a371651e.

It was reverted due to a LINK failure, but reverting didn't fixed either, so I'm relanding it again.

BUG=39102
TEST=trybots

Review URL: http://codereview.chromium.org/2805096/

TBR=mirandac@chromium.org

Review URL: http://codereview.chromium.org/3057018
#542582010-07-30 02:16:35Bump the SPDY protocol version to version 2. Remove "http1.1" and "spdy" from the NPN advertisement string (the proper values are "http/1.1" and "spdy/2", which were included redundantly).


BUG=50550
TEST=existing

Review URL: http://codereview.chromium.org/3044034
#542572010-07-30 02:14:22Add an AppendSwitchASCII to CommandLine, and convert a test to it.

I'm removing all the AppendSwitchWithValue() users due to wstrings, and this is one caller. Since fixing this one caller requires touching many files, I thought I'd isolate this change from the other WithValue->ASCII conversions.

Review URL: http://codereview.chromium.org/2878065
#542562010-07-30 02:13:20linux: don't crash when movind the plugin if the container hasn't been realized

BUG=45890
TEST=repro case from bug, doesn't crash

Review URL: http://codereview.chromium.org/3060030
#542512010-07-30 01:11:07Uncrash BrowserFocusTest.*

It didn't wait for things to finish, which was clearly broken.

TBR=xji

TEST=interactive_ui_tests:BrowserFocusTest.* on Linux, no crashes BUG=50696

Review URL: http://codereview.chromium.org/3005038
#542492010-07-30 00:56:10Revert "Add --enable-speech-input switch and set ENABLE_INPUT_SPEECH=1"

This reverts commit r54235.
#542362010-07-30 00:12:29Attempt to reland code reverted in r52599, to take another look at the page cycler data. There was a lot of noise in the previous data, and since the current page cycler t and t_ref times are close, I'm hoping to see something more conclusive.

TBR=jar
BUG=47227
TEST=none
Review URL: http://codereview.chromium.org/3026032
#542352010-07-30 00:05:23Add --enable-speech-input switch and set ENABLE_INPUT_SPEECH=1

Flip the compile-time enable switch for speech input to on and add a command-line switch to put the functionality behind. The command-line flag will be used both on the Chromium side and in WebKit via WebRuntimeFeatures.

This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146

BUG=none
TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.*

Review URL: http://codereview.chromium.org/3064017
#542202010-07-29 23:07:21Implement more rendering methods on Canvas. Translation in TileImageInt is still wonky.

BUG=none
TEST=see unittests
Review URL: http://codereview.chromium.org/3014043
#542192010-07-29 23:02:53AutoFill: Move the CC icons to webkit/glue/resources. This is a temporary location until they're moved to chrome/common.

BUG=50080
TEST=none

Review URL: http://codereview.chromium.org/3034040
#542182010-07-29 23:02:34CommandLine: add a CopySwitchesFrom() and AppendSwitchPath()

These are two common patterns in Chrome code: copying a subset of switches from one CommandLine to another, and appending a FilePath to a CommandLine. This sets me up to do a lot more deprecation in a follow-up change.

Review URL: http://codereview.chromium.org/3012021
#542112010-07-29 22:44:07Revert 54206 - Mac: Keep groups when sorting task manager, like windows does.

Also fix favicons in task manager.

BUG=32148
TEST=Have a few tabs that share a process. Sort of various columns in the task manager, the process group should stay one block.

Review URL: http://codereview.chromium.org/3029041

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3035040
#542102010-07-29 22:40:12Fix build on ChromiumOS by ASSERTing TRUE in a UI test.

TBR=brettw

Review URL: http://codereview.chromium.org/3061034
#542092010-07-29 22:27:05Speculatively fix ChromiumOS build.

TBR=ahendrickson

TEST=compile?
BUG=48913

Review URL: http://codereview.chromium.org/3027035
#541992010-07-29 21:28:11OwnerManager, allows use of OwnerKeyUtils to take ownership of a device

BUG=chromium-os:4485
TEST=unit tests

Review URL: http://codereview.chromium.org/3058021
#541962010-07-29 21:15:36AutoFill: Temporarily remove a NOTREACHED until WK is fixed to not send in empty strings.

BUG=50674
TEST=none

Review URL: http://codereview.chromium.org/3069012
#541922010-07-29 21:05:55Revert 54168 - Remove PulseAudio 48553 suppression. The memory leaks do not happen if connecting to PulseAudio on the calling (UI) thread at browser init time. Since this change is checked in (r53992), this suppression can be removed.

BUG=3013042,48553
TEST=none

Review URL: http://codereview.chromium.org/2868081
#541912010-07-29 21:03:56GTTF: Increase the limit for QPC drift.

Also update the DCHECK to use an absolute value of the skew for comparison. It could be negative.

TEST=base_unittests
BUG=none

Review URL: http://codereview.chromium.org/3083002
#541902010-07-29 21:02:26Remove an unused IPC message.

TEST=it still compiles
BUG=none
Review URL: http://codereview.chromium.org/3020027
#541892010-07-29 20:58:44Revert parts of http://codereview.chromium.org/2808079 as requested by thestig.

Review URL: http://codereview.chromium.org/3056032
#541882010-07-29 20:58:43[Mac] First pass at final sizing of toolbar items.

Toolbar.xib changes:
- buttons from 31x27 to 29x29 so that the visual is 27x27.
- shift things left to take up opened space.
- omnibox to 29 pixels tall.
- wrench also to 29x29.
- all of that raised a single pixel to recenter.
- swap positions of home and reload.

Modify home-button-adjustment code to reflect rearranged home/reload positions.

Increase Omnibox font size by one point to match increased field height (and Windows Omnibox). Revise various font clients to recognize this. Shift Omnibox baseline and other measurements to account for increased height.

Shift globe/search icon in by one pixel so icons on both sides of Omnibox are 4px from border. Matching shift in popup.

Fix EV-bubble to use appropriate green for text, rather than black.

Push out bubble to have a single-pixel space WRT Omnibox border. Tighten corners to tuck into Omnibox corners. Handle different lhs padding versus location icon (image should end up in same spot, even though the bubble draws outside the image).

BUG=50575
TEST=none

Review URL: http://codereview.chromium.org/3046029
#541872010-07-29 20:55:36Rework somewhat how the folder menu window and main view sizes and positions are calculated. Handle edge case where the top scroll arrow is not showing. Proposed window height was not taking into account the one additional vertical separation.

BUG=46101
TEST=Setup: Create a bookmark folder on the bookmark bar with plenty of bookmarks, more than enough to fill the screen, and so that it is scrollable. 1) Bring up the bookmark folder menu but do not cause it to scroll. 2) Using the contextual menu delete a bookmark midway in the menu. 3) Verify that the top of the menu window and contents do not move relative to the bookmark bar folder button. 4) Bring up the bookmark folder menu again. 5) Cause the menu to scroll up to fill the screen and then scroll it down so that the top scroll arrow is not showing. 6) Using the contextual menu delete a bookmark midway in the menu. 7) Verify that the top of the menu window and contents have not moved in relation to the screen top. 8) Bring up the bookmark folder menu and cause it to scroll such that both the top and bottom scroll arrows are showing. 9) Using the contextual menu, delete a bookmark midway in the menu. 10) Verify that the top scroll arrow, the top-most item showing in the menu, and the menu window have not changed position relative to the top of the window. Note that the contents of the folder menu below the bookmark item being delete should adjust upward to fill the slot originally occupied by the deleted bookmark.

Review URL: http://codereview.chromium.org/3050021
#541862010-07-29 20:55:00Changes to get npapi_pepper_test_plugin recognized on linux. Review URL: http://codereview.chromium.org/2819071
#541852010-07-29 20:54:20AutoFill: Collect UMA stats for AutoFill CC InfoBar.

BUG=50573
TEST=none

Review URL: http://codereview.chromium.org/2868082
#541842010-07-29 20:42:26Review URL: http://codereview.chromium.org/2884048
#541832010-07-29 20:41:45AutoFill: Capitalize "Options" in the AutoFill dialog title.

BUG=50378
TEST=none

Review URL: http://codereview.chromium.org/3018026
#541812010-07-29 20:36:48Recover cookies thrown away because of duplicate creation times.

BUG=50583
TEST=Saw bug in heapcheck, made change, saw bug dissapear.

Review URL: http://codereview.chromium.org/2856069
#541802010-07-29 20:33:44GTTF: Ensure that when we're testing the logging system will not display dialogs.

When I was running ui_tests on Linux at the end there were to xmessage windows on the screen. They shouldn't be there, and they might gum up the bots, especially if it happens on Windows.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2847085
#541792010-07-29 20:30:38Revert 54173 - Hook up the new font API to WebKit. This moves the existing GetFontTable API to the private font interface.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3044029

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/3052024
Loading ChangeLogs...

website software by Techno Joy // New Zealand Web Developers